<html>
<head><meta charset="utf-8"><title>renames · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html">renames</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="195626045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626045">(Apr 28 2020 at 20:58)</a>:</h4>
<p>So, we were talking about some renames:</p>
<ul>
<li><code>Implemented</code> becomes <code>HasImpl</code></li>
<li><code>WellFormed(T: Trait)</code> becomes <code>FullyImplemented(T: Trait)</code>? Maybe?</li>
<li>What about <code>FromEnv</code>?</li>
</ul>



<a name="195626126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626126">(Apr 28 2020 at 20:59)</a>:</h4>
<p>If we agree on some renames, we have a nice <code>good first issue</code></p>



<a name="195626261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626261">(Apr 28 2020 at 21:00)</a>:</h4>
<p>There are some other renames, too</p>



<a name="195626297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626297">(Apr 28 2020 at 21:00)</a>:</h4>
<p>I'd like to rename a few things to match rustc -- notably, I think <code>Substitution</code> should probably become <code>GenericArgs</code>, and <code>Parameter</code> can become <code>GenericArg</code></p>



<a name="195626311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626311">(Apr 28 2020 at 21:00)</a>:</h4>
<p>I also wanted to rename the <code>binders</code> field from <code>Binders</code>, maybe to <code>parameter_kinds</code></p>



<a name="195626339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626339">(Apr 28 2020 at 21:01)</a>:</h4>
<p><span class="user-mention silent" data-user-id="125131">detrumi</span> <a href="#narrow/stream/144729-wg-traits/topic/renames/near/195626045" title="#narrow/stream/144729-wg-traits/topic/renames/near/195626045">said</a>:</p>
<blockquote>
<ul>
<li><code>WellFormed(T: Trait)</code> becomes <code>FullyImplemented(T: Trait)</code>? Maybe?</li>
</ul>
</blockquote>
<p>I'm not sure I like this tbh</p>



<a name="195626349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626349">(Apr 28 2020 at 21:01)</a>:</h4>
<p>and for that matter I hate all the <code>binders</code> fields in the <code>FooDatum</code> structs</p>



<a name="195626409"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626409" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626409">(Apr 28 2020 at 21:01)</a>:</h4>
<p>so undescriptive</p>



<a name="195626422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626422">(Apr 28 2020 at 21:01)</a>:</h4>
<p>even worse</p>



<a name="195626506"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626506" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626506">(Apr 28 2020 at 21:02)</a>:</h4>
<p>well</p>



<a name="195626514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626514">(Apr 28 2020 at 21:02)</a>:</h4>
<p>maybe not worse</p>



<a name="195626559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626559">(Apr 28 2020 at 21:02)</a>:</h4>
<p>but I was finding it a bit weird that <code>ty::Predicate</code> lowers to <em>either</em> a <code>DomainGoal</code> OR <code>QuantifiedWhereClause</code></p>



<a name="195626717"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626717" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626717">(Apr 28 2020 at 21:03)</a>:</h4>
<p>so.. rustc's predicate is not good</p>



<a name="195626748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626748">(Apr 28 2020 at 21:04)</a>:</h4>
<p>or at least, it is kind of a lot of things</p>



<a name="195626775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626775">(Apr 28 2020 at 21:04)</a>:</h4>
<p>and I think could be better factored</p>



<a name="195626817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195626817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195626817">(Apr 28 2020 at 21:04)</a>:</h4>
<p>That was a refactoring you wanted to mentor right</p>



<a name="195627058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195627058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195627058">(Apr 28 2020 at 21:06)</a>:</h4>
<p>Yeah, though I never got organized around it</p>



<a name="195627076"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195627076" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195627076">(Apr 28 2020 at 21:06)</a>:</h4>
<p>I'm going to use a bit of time tnow to try and do some prep work</p>



<a name="195627089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195627089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195627089">(Apr 28 2020 at 21:06)</a>:</h4>
<p>write-up some mentoring things</p>



<a name="195627327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195627327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195627327">(Apr 28 2020 at 21:08)</a>:</h4>
<p>I'm going to: 1) convert <code>from_fallible</code> functions 2) Change mdbook build 3) Figure out if we can publish to <a href="http://crates.io" title="http://crates.io">crates.io</a> by tagging on github</p>



<a name="195631610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195631610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195631610">(Apr 28 2020 at 21:47)</a>:</h4>
<p>So I agree that <code>FullyImplemented</code> might not be the best name</p>



<a name="195631647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195631647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195631647">(Apr 28 2020 at 21:48)</a>:</h4>
<p>but in general there is this "pairing" --</p>



<a name="195631671"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195631671" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195631671">(Apr 28 2020 at 21:48)</a>:</h4>
<p>Every <code>FromEnv</code> should derive from some <code>WellFormed</code> goal that somebody had to prove</p>



<a name="195631706"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195631706" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195631706">(Apr 28 2020 at 21:48)</a>:</h4>
<p>those names don't feel "especially related" to me</p>



<a name="195631721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195631721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195631721">(Apr 28 2020 at 21:48)</a>:</h4>
<p>it'd be nice maybe to align them</p>



<a name="195631756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195631756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195631756">(Apr 28 2020 at 21:49)</a>:</h4>
<p>in this sense, though, distinguishing <code>WellFormed(TraitRef)</code> from <code>WellFormed(Type)</code> is not helpful, unless we also split <code>FromEnv(TraitRef)</code> and <code>FromEnv(Type)</code></p>



<a name="195691154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195691154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195691154">(Apr 29 2020 at 10:55)</a>:</h4>
<p>A silly scheme:  Implemented =&gt; Claimed; FromEnv =&gt;Assuming; WellFormed=&gt; Verified  ,  but i could be very wrong though.</p>



<a name="195702414"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195702414" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195702414">(Apr 29 2020 at 12:46)</a>:</h4>
<p>I like <code>Verified</code></p>



<a name="195702824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195702824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195702824">(Apr 29 2020 at 12:49)</a>:</h4>
<p>It conveys the meaning well imo, but doesn't really play well with how clauses are read, <code>Verified(Type)</code> feels kinda silly</p>



<a name="195721022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195721022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195721022">(Apr 29 2020 at 14:50)</a>:</h4>
<p>I don't think <code>Claimed</code> is <em>quite</em> right</p>



<a name="195721223"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195721223" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195721223">(Apr 29 2020 at 14:51)</a>:</h4>
<p>but I like the out of the box direction</p>



<a name="195736046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/renames/near/195736046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/renames.html#195736046">(Apr 29 2020 at 16:28)</a>:</h4>
<p>ty for pointing out : )</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>